Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #153

Closed
elfring opened this issue Nov 17, 2020 · 3 comments
Closed

reserved identifier violation #153

elfring opened this issue Nov 17, 2020 · 3 comments

Comments

@elfring
Copy link

elfring commented Nov 17, 2020

I would like to point out that identifiers like “_POLLER_H_” and “_WFKAFKACLIENT_H_do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@Barenboim
Copy link
Contributor

Thank you for your advice. We will garentee that all user interfaces are compliant to this standard. But currently we would like to keep our naming system for internal identifiers so long as no complier gives us any warning. Of course we will adjust it if any of our users encounters a real problem. Thank again!

@elfring
Copy link
Author

elfring commented Nov 18, 2020

How do you think about to avoid that this software depends on undefined behaviour?

@Barenboim
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants