Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor in core algorithm and structures #215

Open
3 tasks
benny-n opened this issue Mar 17, 2023 · 0 comments
Open
3 tasks

Major refactor in core algorithm and structures #215

benny-n opened this issue Mar 17, 2023 · 0 comments
Assignees
Labels
⏰ priority:medium Priority: Medium 💡 refactor Type: Refactor 📁 core App: Core

Comments

@benny-n
Copy link
Collaborator

benny-n commented Mar 17, 2023

Sorted by priority:

  • Modify CourseBank to hold its own list of courses (or a predicate which determines if the course belongs to said bank)
  • Refactor the way we handle course replacements - the main obstacle is that a replacement can cause a side effect, for example replacing a course with a course with higher credit can lead to a different overflow calculation - POTENTIAL SOLUTION: always access courses through a dedicated method of CourseBank, which will either return the actual course or a replacement for it.
  • After modifying CourseBank, some rules might become redundant (malag, sport, elective, etc.) - Remove them.
@benny-n benny-n added ⏰ priority:medium Priority: Medium 📁 core App: Core 💡 refactor Type: Refactor labels Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏰ priority:medium Priority: Medium 💡 refactor Type: Refactor 📁 core App: Core
Projects
None yet
Development

No branches or pull requests

2 participants