-
Notifications
You must be signed in to change notification settings - Fork 35
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.save() method is not saving rects. #50
Comments
The purpose of The final result of the packed rects are stored in every rects position inside packer.bins.forEach(bin => {
console.log(bin.rects);
}); This repo is just a simple packing algorithm module, so you have to find your own way storing them. |
Thank you for your quick response! sure i found my own way already but maybe this are points to improve this simple nice module? |
The maxrects-packer/src/geom/Rectangle.ts Lines 1 to 7 in 11fd72c
You can simply use |
BTW, Let's move this post to discussions |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Hi, i run into an issue. I want to save my packer by using
packer.save()
but the rect property of my bins are empty.So i dug into the code and found that the rect prop is not filld here:
maxrects-packer/src/maxrects-packer.ts
Lines 310 to 339 in 11fd72c
To understand the problem i created a sandbox with the problem:
https://codesandbox.io/s/musing-sound-vedd2b?file=/src/index.ts
version 2.7.3
The text was updated successfully, but these errors were encountered: