-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3 - Compatibility w/ external resource manager mixins #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d6b42d.
soir20
added
mc: 1.17.x
This issue affects Minecraft version 1.17.x
compatibility
Something isn't working with another mod
loader: fabric
This issue affects MoreMcmeta on Fabric
loader: forge
This issue affects MoreMcmeta on Forge
labels
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compatibility
Something isn't working with another mod
loader: fabric
This issue affects MoreMcmeta on Fabric
loader: forge
This issue affects MoreMcmeta on Forge
mc: 1.17.x
This issue affects Minecraft version 1.17.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing myself for documentation purposes.
What did you change?
Why did you make this change?
MoreMcmeta and Continuity modify the resource manager in incompatible ways (see #3). The new strategy uses more of Minecraft's existing implementation, which should reduce potential compatibility problems. This change also makes it easier to possibly separate animation, etc. functionality into separate plugins bundled within the mod in the future.
How did you make this change?
ModRepositorySource
that supplies a special required resource pack. It's added via accessor mixin on Fabric and the existing method on Forge.How can others see the effect of your change?
Test MoreMcmeta and Continuity together (Fabric). There's also now an unmovable resource pack added. Other than that, nothing's changed visually.
Links to related issues
#3
Which Minecraft versions does this change apply to?
Did you test this change on both mod loaders?
Did you unit test this change?
Areas for improvement (if any)
There's a couple unit tests that could be added, but it's a few lines of simple adapter code.
Additional notes (if any)
Need to port this to 1.16 for consistency.