Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Prometheus instrument should drop "infras related tags" #113

Closed
soloradish opened this issue Nov 3, 2021 · 0 comments
Closed

Comments

@soloradish
Copy link
Contributor

In
https://github.com/soketi/pws/blob/5f3979ebd305d4a54cc5463b9f1250906bb79167/src/metrics/prometheus-metrics-driver.ts#L7

interface PrometheusMetrics {
    connectedSockets?: prom.Gauge<'app_id'|'node_id'|'pod_id'>;
    newConnectionsTotal?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    newDisconnectionsTotal?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    socketBytesReceived?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    socketBytesTransmitted?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    httpBytesReceived?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    httpBytesTransmitted?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
    httpCallsReceived?: prom.Counter<'app_id'|'node_id'|'pod_id'>;
}

app's instrument should not have infras related tags, leave these to discovery & relabel phase.

connectedSockets?: prom.Gauge<'app_id'>; will be enough.

@rennokki rennokki changed the title Prometheus instrument should drop 'infras related tags' [improvement] Prometheus instrument should drop 'infras related tags' Nov 5, 2021
@rennokki rennokki changed the title [improvement] Prometheus instrument should drop 'infras related tags' [improvement] Prometheus instrument should drop "infras related tags" Nov 5, 2021
@rennokki rennokki closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants