Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airdrop Button Spinner #164

Closed
wants to merge 1 commit into from

Conversation

32jvilla
Copy link

@32jvilla 32jvilla commented Apr 10, 2022

Show a spinning loader icon in the UI while the airdrop button awaits a response

Demo.mov

Issue #150

Notes

  1. I'm unable to generalize this into an intermediary and reusable component, because publicKey / useWallet() doesn't seem to work in callback functions

Show a spinning loader icon in the UI while the airdrop button awaits a response
@DonnySolana
Copy link
Contributor

will review and get back with you. thank you for the submission and thought on this!

@h0lme3
Copy link

h0lme3 commented May 13, 2022

Show a spinning loader icon in the UI while the airdrop button awaits a response

Demo.mov
Issue #150

Notes

  1. I'm unable to generalize this into an intermediary and reusable component, because publicKey / useWallet() doesn't seem to work in callback functions

I think so. We will need loading animation on the button and disable the button while airdropping.
So we can prevent multi request error by not double clicking the airdrop button.
image

@h0lme3
Copy link

h0lme3 commented May 13, 2022

Ohh, I think I have to fetch and merge from origin repo. thanks for your hard working!

Copy link

@h0lme3 h0lme3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
We should be able to merge it.
It would be great if we have loading spinner.

Copy link
Contributor

@DonnySolana DonnySolana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where possible the yarn file should not be changing unless necessary for compatibility reasons. please make sure your yarn updates do not include new changes unless required and mentioned in the update. otherwise the update is looking good. thanks!

@@ -286,6 +286,14 @@
resolved "https://registry.yarnpkg.com/@pedrouid/environment/-/environment-1.0.1.tgz#858f0f8a057340e0b250398b75ead77d6f4342ec"
integrity sha512-HaW78NszGzRZd9SeoI3JD11JqY+lubnaOx7Pewj5pfjqWXOEATpeKIFb9Z4t2WBUK2iryiXX3lzWwmYWgUL0Ug==

"@project-serum/sol-wallet-adapter@0.2.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a need to make so many changes to the yarn lock file?

@DonnySolana
Copy link
Contributor

please get latest and re-request if desired to merge into latest wallet updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants