Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experimental): add voteNotifications websocket method #1647

Merged
merged 3 commits into from
Oct 6, 2023
Merged

feat(experimental): add voteNotifications websocket method #1647

merged 3 commits into from
Oct 6, 2023

Conversation

buffalojoec
Copy link
Collaborator

No description provided.

This was referenced Sep 29, 2023
Merged
Merged
Merged
Merged
@buffalojoec Graphite App
Copy link
Collaborator Author

buffalojoec commented Sep 29, 2023 •
edited by steveluscher
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Sep 29, 2023
Merged
Merged
@mergify mergify bot added the community label Sep 29, 2023
@mergify mergify bot requested a review from a team September 29, 2023 16:07
This was referenced Sep 29, 2023
Merged
Merged
Merged
Merged
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 9c52694 to 28e7608 Compare September 30, 2023 09:40
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 81f4945 to 509e538 Compare September 30, 2023 09:40
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 28e7608 to 78155c3 Compare October 2, 2023 14:49
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 509e538 to d7d0d75 Compare October 2, 2023 14:50
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 78155c3 to 0a85d2c Compare October 3, 2023 10:53
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from d7d0d75 to 8718140 Compare October 3, 2023 10:53
@steveluscher steveluscher force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 0a85d2c to 0b53e8c Compare October 5, 2023 00:21
@steveluscher steveluscher force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 8718140 to 50ee179 Compare October 5, 2023 00:21
@steveluscher steveluscher mentioned this pull request Oct 5, 2023
Closed
steveluscher
steveluscher reviewed Oct 5, 2023
View reviewed changes
packages/rpc-core/src/response-patcher-allowed-numeric-values.ts Outdated
@@ -22,6 +22,7 @@ export function getAllowedNumericKeypathsForNotification(): AllowedNumericKeypat
if (!memoizedNotificationKeypaths) {
memoizedNotificationKeypaths = {
slotsUpdatesNotifications: [['timestamp']],
voteNotifications: [['timestamp']],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typed as i64 on the server, so I don't think you should cast it, unless I'm missing something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I got confused since the UnixTimestamp is a number not bigint, so I thought we always have to cast it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also confused why these numbers are typed the way they are. Casting to number seems reasonable!

steveluscher
steveluscher approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

votespongebob

@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 0b53e8c to 11216d8 Compare October 5, 2023 10:49
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 50ee179 to 5b4bccc Compare October 5, 2023 10:49
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 11216d8 to 0819243 Compare October 5, 2023 11:10
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 5b4bccc to f1b9656 Compare October 5, 2023 11:12
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from f1b9656 to b12c149 Compare October 5, 2023 11:15
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 0819243 to 4d0b8a6 Compare October 5, 2023 12:08
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from b12c149 to dae4387 Compare October 5, 2023 12:09
This was referenced Oct 6, 2023
Merged
Merged
Merged
Merged
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_rootNotifications_websocket_method branch from 4e29d96 to b4673f6 Compare October 6, 2023 08:36
@buffalojoec buffalojoec mentioned this pull request Oct 6, 2023
Merged
Base automatically changed from 09-27-feat_experimental_add_rootNotifications_websocket_method to master October 6, 2023 08:37
@buffalojoec buffalojoec force-pushed the 09-27-feat_experimental_add_voteNotifications_websocket_method branch from 853763b to 24a09be Compare October 6, 2023 08:37
@buffalojoec buffalojoec merged commit 85be7e8 into master Oct 6, 2023
8 of 10 checks passed
@buffalojoec buffalojoec deleted the 09-27-feat_experimental_add_voteNotifications_websocket_method branch October 6, 2023 08:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 1.81.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 6, 2023
Merged
Merged
Merged
Merged
@github-actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 Awaiting requested review from mcintyre94

Assignees
No one assigned
Labels
community released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buffalojoec @steveluscher