Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): declare GetTransactionRpcResult's meta as nullable #1812

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

joncinque
Copy link
Contributor

Problem

As reported in https://solana.stackexchange.com/questions/7981/structerror-at-path-meta-expected-an-object-but-received-null-gettransac, when calling getTransaction directly, the deserialization of the response fails because there's no meta field, and GetTransactionRpcResult requires it.

Note that GetParsedTransactionRpcResult correctly declares the meta field as nullable, and the docs say that meta may be null https://docs.solana.com/api/http#gettransaction

Solution

Make GetTransactionRpcResult consistent with its parsed cousin, and declare the meta as nullable

@joncinque joncinque changed the title fix(legacy): declare transaction meta as nullable fix(legacy): declare GetTransactionRpcResult's meta as nullable Nov 7, 2023
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i c u

@joncinque
Copy link
Contributor Author

I don't have write access to the repo -- can you merge it for me?

@buffalojoec buffalojoec merged commit ffeddf6 into solana-labs:master Nov 7, 2023
6 checks passed
Copy link
Contributor

github-actions bot commented Nov 7, 2023

🎉 This PR is included in version 1.87.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@joncinque joncinque deleted the nullable branch November 7, 2023 14:29
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants