Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug why rollup 1.12.4 fails to generate lib/index.iife.js in CI #327

Closed
mvines opened this issue May 28, 2019 · 6 comments · Fixed by #366
Closed

Debug why rollup 1.12.4 fails to generate lib/index.iife.js in CI #327

mvines opened this issue May 28, 2019 · 6 comments · Fixed by #366
Labels

Comments

@mvines
Copy link
Member

mvines commented May 28, 2019

I had to back out rollup 1.12.4 via 3f011bf and a51f041 as it npm run build in Travis was not generating lib/index.iife.js anymore.

Debug, fix, then let's move back to the latest rollup

@mvines
Copy link
Member Author

mvines commented Jun 15, 2019

512f896

@mvines
Copy link
Member Author

mvines commented Jun 19, 2019

cc: #361

@jstarry
Copy link
Member

jstarry commented Jun 21, 2019

Did a little poking around and my best guess is that it's a dependency version conflict. I'll put together a fix and try it out on travis

from npm install

npm WARN acorn-jsx@5.0.1 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.

package-lock.json

"rollup-plugin-node-globals": {
      "version": "1.4.0",
      "resolved": "https://registry.npmjs.org/rollup-plugin-node-globals/-/rollup-plugin-node-globals-1.4.0.tgz",
      "integrity": "sha512-xRkB+W/m1KLIzPUmG0ofvR+CPNcvuCuNdjVBVS7ALKSxr3EDhnzNceGkGi1m8MToSli13AzKFYH4ie9w3I5L3g==",
      "dev": true,
      "requires": {
        "acorn": "^5.7.3",
        "buffer-es6": "^4.9.3",
        "estree-walker": "^0.5.2",
        "magic-string": "^0.22.5",
        "process-es6": "^0.11.6",
        "rollup-pluginutils": "^2.3.1"
      },

@mvines
Copy link
Member Author

mvines commented Jun 21, 2019

npm 💔

@mvines
Copy link
Member Author

mvines commented Jun 25, 2019

🎉 This issue has been resolved in version 0.16.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants