RPC Client returning incorrect error?

[piazzatron]

Problem

solana/client/src/rpc_custom_error.rs

Line 14 in d5961e9

pub const JSON_RPC_SERVER_ERROR_TRANSACTION_PRECOMPILE_VERIFICATION_FAILURE: i64 = -32006;

There exists an error code JSON_RPC_SERVER_ERROR_TRANSACTION_PRECOMPILE_VERIFICATION_FAILURE which appears unused, at least in this file; it seems that JSON_RPC_SERVER_ERROR_TRANSACTION_SIGNATURE_VERIFICATION_FAILURE may be accidentally returned in it's place:

solana/client/src/rpc_custom_error.rs

Line 111 in d5961e9

JSON_RPC_SERVER_ERROR_TRANSACTION_SIGNATURE_VERIFICATION_FAILURE,

            RpcCustomError::TransactionPrecompileVerificationFailure(e) => Self {
                code: ErrorCode::ServerError(
                    // Should this be the the precompile error rather than signature verification failure?
                    JSON_RPC_SERVER_ERROR_TRANSACTION_SIGNATURE_VERIFICATION_FAILURE, // Intentional?
                ),
                message: format!("Transaction precompile verification failure {:?}", e),
                data: None,
            },

Proposed Solution

Happy to open a PR correcting the error type if this indeed a bug!

[CriesofCarrots]

Yep, that looks like a bug that's been there since that error was added 🤕
Technically that will be a breaking change, but please so open a PR and we'll decide how to roll out. Thank you!