New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest
tag for Docker image.
#22485
Comments
Definitely a good first issue. Patches welcome! 🙂 |
Should the |
Right now we have three Docker tags: It's not clear to me what a The solana Docker image is mostly for internal CI usage anyway. It's not a public artifact that we advertise for ecosystem use |
As per convention, the latest points to the latest stable image (safest IMO)
It's better to get the safest ci to get started. Since the overview page is empty, I ended up cloning the repo and building manually, till I realized other tags exist. |
The "https://hub.docker.com/r/solanalabs/solana" page shows Docker Pull Command as "docker pull solanalabs/solana", which assumes the existence of solana:latest tag, hence the error. The correct pull command should be "docker pull solanalabs/solana:<correct_tag>", such as "docker pull solanalabs/solana:stable" |
Is this the kind of script we would add the tag to? https://github.com/solana-labs/solana/blob/master/sdk/docker-solana/build.sh Seems like there are a few of these scripts. Or am I looking in the wrong place. |
Problem
When
$ docker pull solanalabs/solana
is executed, no image is pulled becauselatest
tag is not specified now.Proposed Solution
Add
latest
when new version is released, if this is a good first issue, I wanna contribute.The text was updated successfully, but these errors were encountered: