Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest tag for Docker image. #22485

Closed
Krout0n opened this issue Jan 13, 2022 · 6 comments
Closed

Add latest tag for Docker image. #22485

Krout0n opened this issue Jan 13, 2022 · 6 comments
Labels
good first issue Good for newcomers

Comments

@Krout0n
Copy link

Krout0n commented Jan 13, 2022

Problem

When $ docker pull solanalabs/solana is executed, no image is pulled because latest tag is not specified now.

Proposed Solution

Add latest when new version is released, if this is a good first issue, I wanna contribute.

@t-nelson t-nelson added the good first issue Good for newcomers label Jan 13, 2022
@t-nelson
Copy link
Contributor

Definitely a good first issue. Patches welcome! 🙂

@Krout0n
Copy link
Author

Krout0n commented Jan 14, 2022

Should the latest be updated only at Mainnet release? BTW I'm reading sdk/docker-solana/build.sh now but feeling that there's more.

@mvines
Copy link
Member

mvines commented Jan 14, 2022

Right now we have three Docker tags: edge, beta and stable. These correspond to the names of our release channels: https://github.com/solana-labs/solana/blob/master/RELEASE.md#channels

It's not clear to me what a latest would mean. It could be any or all of these three channels depending on what the user is looking for. This is the main reason why we don't have a latest.

The solana Docker image is mostly for internal CI usage anyway. It's not a public artifact that we advertise for ecosystem use

@vintageplayer
Copy link

As per convention, the latest points to the latest stable image (safest IMO)

docker pull solanalabs/solana right now throws:

Error response from daemon: manifest for solanalabs/solana:latest not found: manifest unknown: manifest unknown

It's better to get the safest ci to get started. Since the overview page is empty, I ended up cloning the repo and building manually, till I realized other tags exist.

@xiangzhu70
Copy link
Contributor

The "https://hub.docker.com/r/solanalabs/solana" page shows Docker Pull Command as "docker pull solanalabs/solana", which assumes the existence of solana:latest tag, hence the error.

The correct pull command should be "docker pull solanalabs/solana:<correct_tag>", such as "docker pull solanalabs/solana:stable"

@LukasDeco
Copy link

Is this the kind of script we would add the tag to? https://github.com/solana-labs/solana/blob/master/sdk/docker-solana/build.sh Seems like there are a few of these scripts. Or am I looking in the wrong place.

@mvines mvines closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants