fix: don't override a transaction's recentBlockhash when calling simulate if it's already set #24280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulate has been overriding the recentBlockhash of the passed Transaction which can be considered destructive and with side effects. Since the purpose of this function is to purely simulate, it should not override recentBlockhash if it has already been set Refs solana-labs#24279
jstarry
changed the title
|
Can you run prettier? And don't worry about the commit lint |
|
Prettier'd! |
Codecov Report
@@ Coverage Diff @@
## master #24280 +/- ##
===========================================
- Coverage 81.8% 70.1% -11.7%
===========================================
Files 581 36 -545
Lines 158312 2236 -156076
Branches 0 316 +316
===========================================
- Hits 129518 1568 -127950
+ Misses 28794 558 -28236
- Partials 0 110 +110 |
|
Thanks! A patch release will be rolled out shortly |
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 29, 2022
…late if it's already set (solana-labs#24280) * Update simulate to add blockhash if not exist Simulate has been overriding the recentBlockhash of the passed Transaction which can be considered destructive and with side effects. Since the purpose of this function is to purely simulate, it should not override recentBlockhash if it has already been set Refs solana-labs#24279 * Apply prettier
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Jun 30, 2022
…late if it's already set (solana-labs#24280) * Update simulate to add blockhash if not exist Simulate has been overriding the recentBlockhash of the passed Transaction which can be considered destructive and with side effects. Since the purpose of this function is to purely simulate, it should not override recentBlockhash if it has already been set Refs solana-labs#24279 * Apply prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulate has been overriding the recentBlockhash of the passed
Transaction which can be considered destructive and with side effects.
Since the purpose of this function is to purely simulate, it should not
override recentBlockhash if it has already been set
Refs #24279