Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRecentPerformanceSamples(): Filter to return results since a certain slot only #29771

Closed
ilya-bobyr opened this issue Jan 18, 2023 · 0 comments
Assignees

Comments

@ilya-bobyr
Copy link
Contributor

Problem

Performance stats are computed by each node, based on the node own performance.
For nodes that are running in sync with the rest of the network, node stats match network stats close enough.
But when a node is catching up with the rest of the network, it might be reporting stats that could deviate from the rest of the network performance.

For example, the number of transactions is computed based on the number of transactions in blocks a given node has processed in the last 60 seconds.
When the node is running in sync with the rest of the network, this number will show the network performance.
When the node is catching up, this number will show the node performance.

Ideally, it would be great to show both numbers at all times: one set of stats for the network, and one for the node.
But, for now, we only report the node stats.

If one wants to monitor specific a given node, they are in luck.
If one wants to see the network performance, they need a node that is in sync.

This is a follow-up to a discussion in #29159.
Specifically these comments:

Proposed Solution

Add minContextSlot to getRecentPerformanceSamples().
It specifies a minimum slot that the node have already processed, in order to return a successful response.
By choosing the target slot to be close to the tip of the chain, the caller can ensure that the node is reasonably up-to-date.

@ilya-bobyr ilya-bobyr self-assigned this Jan 18, 2023
@ilya-bobyr ilya-bobyr changed the title getRecentPerformanceSamples(): Filter to return results since a certain slot getRecentPerformanceSamples(): Filter to return results since a certain slot only Jan 18, 2023
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
@ilya-bobyr ilya-bobyr removed the stale [bot only] Added to stale content; results in auto-close after a week. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant