Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators cannot verify mining proofs efficiently #4963

Open
sagar-solana opened this issue Jul 8, 2019 · 1 comment
Open

Validators cannot verify mining proofs efficiently #4963

sagar-solana opened this issue Jul 8, 2019 · 1 comment

Comments

@sagar-solana
Copy link
Contributor

@sagar-solana sagar-solana commented Jul 8, 2019

Problem

Validators cannot verify mining proofs right now since the function that does the verification assumes the offsets are the same for all proofs. This function also does not correctly generate offsets.

Proposed Solution

The verification function (chacha_cbc_encrypt_file_many_keys) needs to be updated to understand how proofs are generated.

  • Per segment that is being verified, this function needs to map encryption keys to offsets per key so that the hashes that are generated are mapped to each key.
  • Offset generation on the validator needs to factor in the segment size correctly and then we know the sample range by num_bytes/block_size.

Tag: @sakridge

@sagar-solana sagar-solana added this to the Mavericks v0.18.0 milestone Jul 8, 2019
@sagar-solana

This comment has been minimized.

Copy link
Contributor Author

@sagar-solana sagar-solana commented Jul 8, 2019

@sakridge you think you'll be able to look into this at some point?

@mvines mvines modified the milestones: Mavericks v0.18.0, v0.19.0 Aug 8, 2019
@mvines mvines added this to To do in Soft Launch - Archivers via automation Sep 3, 2019
@mvines mvines modified the milestones: Jaws v0.19.0, Sultans v0.21.0 Sep 3, 2019
@mvines mvines modified the milestones: Supertubes v0.22.0, v0.23.0 Nov 25, 2019
@mvines mvines modified the milestones: Tofino v0.23.0, The Future! Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Storage Mining
  
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.