Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: Separate markdown from classification generation #192

Merged
merged 1 commit into from Oct 20, 2021

Conversation

joncinque
Copy link
Contributor

Problem

Markdown and epoch classification output are tied together, but the stake pool's mainnet run needs the stake pool testnet classification. At the same time, we don't want to clobber the markdown generated by the not-a-stake-pool run.

Solution

Add an --epoch-classification flag, which works exactly the same way as the markdown flag, allowing for more fine-grained control over epoch classification output.

@joncinque
Copy link
Contributor Author

Merging to run a test, post-merge review will be very welcome if possible!

@joncinque joncinque merged commit 57fef0f into solana-foundation:master Oct 20, 2021
@joncinque joncinque deleted the bot-classification branch October 20, 2021 18:08
@t-nelson
Copy link
Contributor

lgtm. is it time to just kill markdown output? the sfdp website should be a better experience and AFAIK the markdown is so large that the github wiki won't render it in most cases

@joncinque
Copy link
Contributor Author

is it time to just kill markdown output? the sfdp website should be a better experience and AFAIK the markdown is so large that the github wiki won't render it in most cases

that makes sense to me. maybe @danpaul000 or @mvines have an opinion on this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants