Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny adventure two #85

Merged
merged 12 commits into from Nov 27, 2022

Conversation

Woody4618
Copy link
Contributor

Second tutorial which lets the developer give out sol to reward the players.

Would be super cool, if you or some anchor developer you know could review the program so that I am not teaching something wrong.

I asked a few people I know already and they said it makes sense how it is. But just to be sure.

Also do you think this is still easy or rather medium?

Copy link
Member

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tutorial, I've added some comments. Using AccountInfo when transfering lamports between accounts is a really bad idea. One could supply any account there since there are no checks.

@acheroncrypto
Copy link
Member

Thank you for fixing those! Are you happy with the current state of the tutorial?

@Woody4618
Copy link
Contributor Author

Woody4618 commented Nov 26, 2022

Thank you for fixing those! Are you happy with the current state of the tutorial?

Thank you for pointing them out :D Just tested one more time and added a video url. Looking good from my side. Do you have any other feedback? Is this how you envisioned the tutorials? I would like to do one or two more. A complete game over multiple files and then link client examples to the tutorial games.

@acheroncrypto
Copy link
Member

Also do you think this is still easy or rather medium?

I would say this is still pretty easy.

Just tested one more time and added a video url.

Video explanations are very useful, thank you for making those!

Is this how you envisioned the tutorials?

Let's say this is the beginning stages of my vision. I would like to see some more advanced tutorials that are using React to make the tutorial but we have to start at somewhere and we currently need Markdown tutorials too!

I will also be adding couple of hello world tutorials next week for all frameworks to show best practices.

I would like to do one or two more. A complete game over multiple files and then link client examples to the tutorial games.

That's awesome, let me know if you need anything!

@Woody4618
Copy link
Contributor Author

Cool, looking forward to your tutorials and what you will be building in the future :)
If you want me to help test new features let me know.

@acheroncrypto acheroncrypto merged commit 07f8308 into solana-playground:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants