Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event timeseries support to plotting module #394

Merged
merged 3 commits into from Apr 22, 2020

Conversation

lboeman
Copy link
Member

@lboeman lboeman commented Apr 16, 2020

  • Closes Update plotting module to handle events #393 .
  • I am familiar with the contributing guidelines.
  • Tests added.
  • Updates entries to docs/source/api.rst for API changes.
  • Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Adds ability to plot event timeseries to the plotting module. Will need to be rebased on master when #361 is merged. A screenshot of the event timeseries is as below.
Screenshot from 2020-04-16 15-53-25

@lboeman lboeman changed the title Event plotting Add event timeseries support to plotting module Apr 16, 2020
@wholmgren wholmgren added this to the 1.0 beta 5 milestone Apr 22, 2020
@wholmgren wholmgren added the enhancement New feature or request label Apr 22, 2020
@wholmgren
Copy link
Member

@lboeman ready for rebase/merge

@lboeman
Copy link
Member Author

lboeman commented Apr 22, 2020

@wholmgren updated with some minimal tests, anything else before this gets merged?

@wholmgren
Copy link
Member

probably worth a whatsnew entry

@lboeman lboeman merged commit d4eaa95 into SolarArbiter:master Apr 22, 2020
@lboeman lboeman deleted the event-plotting branch August 16, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plotting module to handle events
2 participants