adjust how reference forecast names are truncated #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wholmgren
reviewed
Sep 14, 2020
Co-authored-by: Will Holmgren <william.holmgren@gmail.com>
wholmgren
reviewed
Sep 15, 2020
| # ensure suffix not more than 50 characters to allow | ||
| # for some site identification in the name | ||
| if len(suffix) > 50: | ||
| raise ValueError('Template forecast name is too long') |
There was a problem hiding this comment.
do we also need a check like if len(site_name.split(' ')[0]) > 13: raise ValueError?
There was a problem hiding this comment.
We could. I am OK with having no site specifier at all, but probably best just to raise the error when creating the forecast instead of something odd slipping through
wholmgren
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/source/api.rstfor API changes.docs/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).First, abbreviate Persistence to Pers. then start cutting whole words out of the site name