Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ARM GHI with Best Estimate GHI #716

Merged
merged 12 commits into from Sep 16, 2021
Merged

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 19, 2021

  • Closes #xxxx .
  • I am familiar with the contributing guidelines.
  • Tests added.
  • Updates entries to docs/source/api.rst for API changes.
  • Adds descriptions to appropriate "what's new" file in docs/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren wholmgren added this to the 1.0.5 milestone Aug 19, 2021
@wholmgren
Copy link
Member Author

Warning added in 32ceb99 fired as expected:

2021-09-07 16:38:44,046 WARNING Duplicate index values in sgpmetE9.b1. Keeping last.

The deduplicator is needed at this level of the code because reference_observations/arm.py concatenates the irradiance and the meteorological data along the columns, and this only works if there are no duplicates in either dataframe. Debatable whether the deduplicator should be here or in reference_observations/arm.py. Going with the most straightforward approach for now.

The first deduplicator added in a268a94 did solve the problem for ARM sites that have duplicates in both the irradiance and the met data. Sentry logs indicate that this problem has also occurred with at least a MIDC site, so let's keep these lines too.

@wholmgren wholmgren changed the title arm notes replace ARM GHI with Best Estimate GHI Sep 15, 2021
@wholmgren wholmgren added bug Something isn't working enhancement New feature or request labels Sep 15, 2021
@wholmgren wholmgren marked this pull request as ready for review September 15, 2021 22:40
@wholmgren wholmgren merged commit 761d06b into SolarArbiter:master Sep 16, 2021
@wholmgren wholmgren deleted the arm branch September 16, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants