Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: implement more automated fitting algorithm #3

Open
solarchemist opened this issue Nov 29, 2022 · 0 comments
Open

Suggestion: implement more automated fitting algorithm #3

solarchemist opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@solarchemist
Copy link
Owner

From a discussion with a valued colleague, who raised the prospect of using different approach to the "band edge detection" part of the algorithm.

Instead of having the user specify bg.limits, could we implement a function that finds the linear fit that a) maximises the fitted number of points, while b) maximising some goodness-of-fit measure (the latter remains to be defined).
I think such an approach, if implemented naively, would result in a large computation penalty.

The major upside is the elimination of two (possibly four) of the six input parameters.

@solarchemist solarchemist added the enhancement New feature or request label Nov 29, 2022
@solarchemist solarchemist self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant