Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_undef_values required stdlib 4.2.0, dependency not set properly #109

Closed
zxjinn opened this issue Apr 19, 2015 · 1 comment · Fixed by #111
Closed

delete_undef_values required stdlib 4.2.0, dependency not set properly #109

zxjinn opened this issue Apr 19, 2015 · 1 comment · Fixed by #111

Comments

@zxjinn
Copy link
Contributor

zxjinn commented Apr 19, 2015

Hey guys, first of all: I appreciate all the hard work you're doing here, this module is great.

I noticed a small problem when pulling from master (specifically I'm working off of: 0bbbea6). When pulling the module via librarian-puppet it checks the dependencies in the metadata.json file. I currently have puppetlabs-stdlib 4.1.0 installed, which passed the dependency check in the metadata.json file, because that file claims your module only requires puppetlabs-stdlib version 0.1.6 or greater. However, a the new function delete_undef_values introduced in this commit requires at least puppetlabs-stdlib 4.2.0.

It seems that the metadata.json file needs to be updated to reflect that fact. I can submit a PR if you desire, I'm more than willing to do that.

Thanks!

@solarkennedy
Copy link
Contributor

Ah! Yes please, I did not realize that function was only available in 4.2.0 or later. Please yes a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants