Add service_config_hash to customize services #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 10, 2019
manifests/service.pp
Outdated
| @@ -41,6 +65,7 @@ | |||
| $id = $title, | |||
| $port = undef, | |||
| $service_name = $title, | |||
| $service_config_hash = [], | |||
There was a problem hiding this comment.
Could you add a datatype to the parameter? Also in your example it's a hash, here it is an array.
There was a problem hiding this comment.
Gotcha, wasn't clear on the datatypes since some had and some don't, and there weren't any in the service manifest. All should be good now.
There was a problem hiding this comment.
It takes some time to convert all old code to datatypes, but I think it should be enforced for new parameters.
bastelfreak
added
enhancement
bastelfreak
reviewed
Jan 13, 2019
| @@ -41,6 +65,7 @@ | |||
| $id = $title, | |||
| $port = undef, | |||
| $service_name = $title, | |||
| Hash $service_config_hash = {}, | |||
There was a problem hiding this comment.
Can you please align the = chars and enforce the structure of the Hash?
There was a problem hiding this comment.
Alignment done, enforcement delayed per our slack conversation
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Add service_config_hash to customize services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow you to add new features, such as the new connect options.