Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from anchor pattern to contain function #475

Merged
merged 1 commit into from Apr 11, 2019
Merged

Switch from anchor pattern to contain function #475

merged 1 commit into from Apr 11, 2019

Conversation

natemccurdy
Copy link
Contributor

The contain function is preferred over the anchor pattern when on Puppet 4+.

This also:

  • Removes the resource-like declaration of the sub classes which makes the code a bit more portable.
  • Accounts for the $consul::notify_service variable not existing anymore in init.pp

@natemccurdy
Switch from anchor pattern to contain function
5698ea5 
The contain() function is preferred over the anchor pattern when on
Puppet 4+.
@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit 0fc6eec into voxpupuli:master Apr 11, 2019
@natemccurdy natemccurdy deleted the contain_not_anchor branch April 11, 2019 21:51
spuder pushed a commit to spuder/puppet-consul that referenced this pull request Feb 25, 2020
@bastelfreak
Merge pull request voxpupuli#475 from natemccurdy/contain_not_anchor
49a2c26 
Switch from anchor pattern to contain function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natemccurdy @bastelfreak