Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect colors when creating custom theme #6

Closed
bcaccia opened this issue Jan 19, 2020 · 3 comments
Closed

Incorrect colors when creating custom theme #6

bcaccia opened this issue Jan 19, 2020 · 3 comments

Comments

@bcaccia
Copy link

bcaccia commented Jan 19, 2020

Environment:

  • Masterplan v0.1.1(compiled from master branch)
  • Kubuntu 18.04
  • i3wm 4.14.1

Repro:

  1. Duplicate an existing theme in /masterplan/bin/linux_amd64/assets/themes and rename it. I called mine Gruvbox_dark.json
  2. Change the GUI_INSIDE property in the json file to an obvious color such as 204, 36, 29, 1
  3. Save the changes, launch Masterplan, and load your theme.

Expected:
The background will be the following color:
image

Bug:

The background is black:
image

If I change every value in the Gruvbox_dark.json file to that red, the whole UI is completely black.
To rule out that just that color was an issue, I tested with several other colors from the Gruvbox palette located here: https://github.com/morhetz/gruvbox

@SolarLune
Copy link
Owner

SolarLune commented Jan 19, 2020

The alpha argument in your example is 1, which is basically invisible. The format for each color defined in themes is RGBA. Each value spans from 0 to 255 max.

@bcaccia
Copy link
Author

bcaccia commented Jan 19, 2020

Thanks, total user error. Confirmed this works correctly when the value is set to 255. This can be closed.

@SolarLune
Copy link
Owner

OK, cool, just wanted to be sure. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants