NH-23786: minimal passing automated tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuan-cao-swi
requested review from
cheempz and
tammy-baylis-swi
as code owners
cheempz
reviewed
Oct 18, 2022
xuan-cao-swi
force-pushed
the
NH-23786
branch
from
464b182
to
b2c391d
Compare
cheempz
reviewed
Oct 28, 2022
There was a problem hiding this comment.
Looks good @xuan-cao-swi! I left a couple comments, the main one being whether we really have to hardcode a permanent skip for the wicked pdf test.
Also, can you update the PR description to highlight the changes made for redis?
| @@ -238,7 +238,7 @@ | |||
| end | |||
|
|
|||
| it "traces pdfs from the 'wicked' controller" do | |||
| skip if @skip_wicked | |||
| skip | |||
There was a problem hiding this comment.
I see @skip_wicked being set to true in https://github.com/solarwindscloud/solarwinds-apm-ruby/blob/main/test/frameworks/rails_shared_tests.rb. Can it be used to also skip this test?
cheempz
changed the title
cheempz
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact?
Alpine 3.12 -> 3.16.2
Ubuntu 18.04 -> 20.04
action/checkout@v2 -> action/checkout@v3 (ref)
redis library is set to
<=5.0.0to overcome the redis library upgrade (also affected resque)