Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip actions] update gemspec for rebranding #5

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Conversation

xuan-cao-swi
Copy link
Contributor

No description provided.

Copy link

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xuan-cao-swi! Minor change please, let's use a placeholder for homepage.

solarwinds_apm.gemspec Outdated Show resolved Hide resolved
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuan-cao-swi I should have clarified -- the only change needed was everywhere we indicate "homepage", let's use the placeholder URL (which eventually will redirect to a product overview page). The actual link to the agent documentation should stay as https://documentation.solarwinds.com/en/success_center/observability/default.htm#cshid=config-ruby-agent

solarwinds_apm.gemspec Outdated Show resolved Hide resolved
solarwinds_apm.gemspec Outdated Show resolved Hide resolved
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 631bba1 into main Sep 22, 2022
@cheempz cheempz deleted the NH-21450 branch August 3, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants