Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching and throwing an exception when not a trusted app #13

Open
javiergarber opened this issue May 25, 2021 · 2 comments
Open

Catching and throwing an exception when not a trusted app #13

javiergarber opened this issue May 25, 2021 · 2 comments

Comments

@javiergarber
Copy link

Hi, I'm doing a node app with the library, and there is no way of catching the exception thrown when the app is not added as "trusted application". You should consider catching the exception when using the solid-auth-fetcher and throwing a new exception when using the "login" method, for the users of the library to handle it. Thank you in advance

@jeff-zucker
Copy link
Member

Thanks much for your suggestion. I am looking at ways of not requiring the trusatedApp setting. If I can get that working, it won't be a problem since you won't have to set trustedApp at all. If I can't, I'll follow your suggestion and give a warning.

@javiergarber
Copy link
Author

Thank you so much, looking forward see your discoveries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants