Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📚 deprecate ui-surrounding-map #944

Open
5 of 11 tasks
karlbaumhauer opened this issue Apr 12, 2024 · 3 comments
Open
5 of 11 tasks

docs: 📚 deprecate ui-surrounding-map #944

karlbaumhauer opened this issue Apr 12, 2024 · 3 comments
Labels
CL-migration All components which need to be migrated from Component Library 🔧 code needs changes in code

Comments

@karlbaumhauer
Copy link
Contributor

karlbaumhauer commented Apr 12, 2024

Description

As the ui-surrounding-map will not be provided as a component (see #308), the component needs to be added to the discontinued list and a migration guide, which explains the usage of the Google Maps Style Wizzard in combination with #573, should be written.

Todos

  • Design: formulate a design guide on how to use the wizzard and what design expects from users (use default and under which circumstances to change it) => add in this ticket as a comment. @van-nguyen-ht
  • Development: create the migration guide on GitHub and add the explanation to it.
  • Development: add the ui-surrounding-map to the discontinued list in the migration guide intro

Where to put the documentation

GiHub/Storybook/Figma

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@karlbaumhauer karlbaumhauer added pre-refinement Tickets which are still in the definition phase and need to be prepared for pre-/refinement. 🎨 figma needs changes in Figma 🔧 code needs changes in code labels Apr 12, 2024
@karlbaumhauer karlbaumhauer mentioned this issue Apr 12, 2024
13 tasks
@karlbaumhauer karlbaumhauer added CL-migration All components which need to be migrated from Component Library and removed pre-refinement Tickets which are still in the definition phase and need to be prepared for pre-/refinement. labels Apr 12, 2024
@van-nguyen-ht van-nguyen-ht self-assigned this Apr 24, 2024
@van-nguyen-ht
Copy link
Contributor

van-nguyen-ht commented Apr 24, 2024

Screenshot 2024-04-23 at 18 15 10

Users can use Google Maps Style Wizzard in Standard theme to customize view option. Due to brand preference to maintain UI look and feel, customisation factors should be adjusted with consideration, extreme styling (i.e.: Retro) should be avoided.

A marker is an icon that appears over the map, indicating a location. sd-map-marker component can be used to mark a specific location with content. The map markers come in two different options: Main marker & Place marker

@karlbaumhauer
Copy link
Contributor Author

thx @van-nguyen-ht

@yoezlem I put this into refinement correct?

@van-nguyen-ht
Copy link
Contributor

@coraliefeil can you have a look at the text if sth should be added? Thank you

@coraliefeil coraliefeil removed the 🎨 figma needs changes in Figma label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-migration All components which need to be migrated from Component Library 🔧 code needs changes in code
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants