Add many more helper methods to player #104

alr2413 · 2020-09-09T19:54:16Z

This PR Only implemented and tested on Android.
Features:

fix black screen issue on android devices when rotation changes.
get list of embedded audio tracks (also changed some names to be more like vlc conventions)
get list of embedded subtitle tracks (also changed some names to be more like vlc conventions)
get list of embedded video sections
support local and network videos (isLocalVideo parameter) and subtitles (isLocalSubtitle parameter)
added casting ability to an external display device
added autoplay & looping options
set/get subtitle delay, set/get audio delay
and more .... :)

Also, the example app is updated to show some of these changes.

…player # Conflicts: # lib/flutter_vlc_player.dart

added getTime, getPlaybackSpeed and getVolume methods. edited media player opening status to notify that the target url is loading.

fix various bug added casting feature

alr2413 · 2020-09-09T19:59:34Z

I've tried to add IOS implementation of this changes, but it's not clear to me how to do that.
I hope someone implement that.

Also, since I've add many parameters to vlc initialize method, I've change that method to support naming parameter structure, so it's not compatible with the prev version of this package. Maybe this PR (after IOS implementation) should be considered as a major revision.

Thanks.

topilski · 2020-09-10T05:56:44Z

Nice work @alr2413

csongorkeller · 2020-09-10T06:17:41Z

Big thanks for fixing it 👍

csongorkeller · 2020-09-10T09:24:39Z

Can you point on @alr2413 which part fixes the android black screen issue? So I can quickly check that on my end as well. THanks in advance

alr2413 · 2020-09-10T11:00:57Z

Can you point on @alr2413 which part fixes the android black screen issue? So I can quickly check that on my end as well. THanks in advance

The part of code that was in "onSurfaceTextureAvailable" method, was moved to a Runnable closure.

topilski · 2020-09-10T15:41:12Z

@alr2413 how can I see swift part not ready?

alr2413 · 2020-09-10T17:28:04Z

@alr2413 how can I see swift part not ready?

See What? As I mentioned "This PR Only implemented and tested on Android."

solid-software · 2020-09-11T12:41:58Z

Thanks for your work @alr2413! We hope that somebody can help with the iOS part to make it complete. Also do you mind resolving all of the conflicts?

mitchross

I will do iOS Part..

example/lib/main.dart

alr2413

Thanks for your work @alr2413! We hope that somebody can help with the iOS part to make it complete. Also do you mind resolving all of the conflicts?

As I mentioned, some changes are based on vlc convention (like "audioTrack" instead of "sound"). That's why I proposed to use major revision for the next release.

example/lib/main.dart

mitchross · 2020-09-11T20:04:46Z

hey @alr2413 do you wanna to add me as a contributor to your repo of this fork? I can help resolve conflicts and complete iOS part

csongorkeller · 2020-09-12T18:01:09Z

@alr2413 I've checked in emulator, and the rotation doesn't work for me with the example app in the repo. You also tested with the example app?

alr2413 · 2020-09-12T18:23:56Z

@alr2413 I've checked in emulator, and the rotation doesn't work for me with the example app in the repo. You also tested with the example app?

What do you mean "the rotation doesn't work"?
Yes, I've tested on my real android device and it's working.

csongorkeller · 2020-09-12T18:54:35Z

@alr2413 I've checked in emulator, and the rotation doesn't work for me with the example app in the repo. You also tested with the example app?

What do you mean "the rotation doesn't work"?

Yes, I've tested on my real android device and it's working.

Well,
I've tried to run the example app in the project. And the player doesn't start at all on my end. And when I rotate the screen, I got just a white background instead of the player object. So basically the whole player don't really work for me, and therefore the rotation also doesnt. Can you upload the project hete in a zip, where you run the player in landscape? So I can check with my environment too.
I hope you can help me with this. Thanks in advance, and many thanks for fixing vlc for all of the flutter enthusiasts.

mitchross · 2020-09-12T20:45:25Z

@csongorkeller Please hold tight. Im actively working on helping out @alr2413. Im working on his code right now...

Swift help

csongorkeller · 2020-09-14T10:40:17Z

android seems like working. Good job @alr2413. But I have an issue with disposing the player. If I want to change the video, I dispose the player with the method you've implemented, but for the new player, I got a black screen without any playing. Do you have any idea what I'm doing wrong?

mitchross · 2020-09-17T14:15:28Z

Getting close on fixing casting on iOS, will have a update for this PR hopefully by tonight

[DRAFT] WIP - Cast devices ios

topilski · 2020-09-18T18:53:40Z

Hello, that's only my machine issue?

mitchross · 2020-09-18T21:43:11Z

@topilski that is not on the latest commit. you appear to behind.

mitchross · 2020-09-18T21:44:39Z

@solid-software This code is ready for merge. I have reviewed it, tested it, developed on it.

I worked with @alr2413 on the side and brought in @amadeu01

topilski · 2020-09-19T05:20:02Z

@mitchross @alr2413 @amadeu01 thank you for your work guys!

fix minor issue in android capture method added event dispatcher to ios cast device add/remove updated example code

fix spacing issue in readme

alr2413 · 2020-09-21T06:36:32Z

Ping @solid-software,
now the code is ready for merge.

solid-software

Great job @alr2413 @mitchross - I'm blown away with the changes you guys have made!

I've added couple small comments/suggestions - please take a look and let me know what you think.

I think 4.0 would be a game changer - thanks again for your work on this!

android/src/main/java/software/solid/fluttervlcplayer/FlutterVideoView.java

lib/flutter_vlc_player.dart

Updated method docs

alr2413 · 2020-09-21T09:24:15Z

@solid-software I've done that.
Also, if you've any suggestion about versioning let me know.
tnx

mitchross · 2020-09-21T13:04:19Z

@solid-software After this PR is merged there is a few more clean up tasks I'll do in follow up PRs to migrate the Android Plugin to V2 https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration

solid-software

LGTM - thanks @alr2413 @mitchross !

alr2413 · 2020-09-22T10:19:06Z

@solid-software, @mitchross
I think we should review all opened issues, and close theme if they're solved with this release.

pharshdev · 2020-09-22T11:36:59Z

I think the major issues still are:

[A] the "player state change", when the widget is rebuilt which could be from something as simple as orientation change or calling setstate.
Steps to reproduce:

Pause the player
Tilt the device or press a button that calls setstate.

Desired state: Video player paused.
Observed state: Video player starts playing.

[B] Not adhering to App lifecycle. Any video player should be auto paused when the phone screen is turned off. This plugin would infact start playing the video even when the video was paused. Needless to say, a playing video would continue playing.

[C] Player doesnt respond well to player's widget resizing dynamically. I have an app that supports PIP and when i send a running video to PIP, there's a second or two delay before the video starts re-rendering. All this while, the audio is playing fine. Although not majorly observed, this happens when orientation change too.

It looks like we're still missing something in the native implementations as the official vlc player doesnt have these issues.

PS: You can run into these issues even with the example code.

mitchross · 2020-09-22T12:15:36Z

@pharshdev i'll take care of A,B,C with the Android 2.0 Plugin update migration

alr2413 · 2020-09-22T12:29:55Z

@pharshdev , @mitchross
Yea, the "A" situation is based on the written code.
Before I clean up code, I've "wasPlaying" variable in Runnable method to check that situation, but I don't remember why I've commented that line.

alr2413 and others added 7 commits August 3, 2020 23:12

added error handling

ab21155

added error handling

bbc0926

added error handling

9a23aa2

Merge branch 'master' of git://github.com/solid-software/flutter_vlc_…

b2f7973

…player # Conflicts: # lib/flutter_vlc_player.dart

Added some helper method.

b10208d

added getTime, getPlaybackSpeed and getVolume methods. edited media player opening status to notify that the target url is loading.

updated swift code

fe67ce1

Add many helper function

a7e04a8

fix various bug added casting feature

alr2413 mentioned this pull request Sep 9, 2020

Screen gets black on android when orientation changes #103

Open

alr2413 mentioned this pull request Sep 11, 2020

Add Function to Change/ADD subtitle and change the audio track #91

Merged

mitchross reviewed Sep 11, 2020

View reviewed changes

example/lib/main.dart Outdated Show resolved Hide resolved

alr2413 commented Sep 11, 2020

View reviewed changes

example/lib/main.dart Outdated Show resolved Hide resolved

Change android vlc dependency to official LibVLC

b462e20

mitchross and others added 4 commits September 12, 2020 16:52

fix swift

16d4ca7

working subtitles

e270d83

PR Comments

f1afa63

Merge pull request #1 from mitchross/swift-help

0632142

Swift help

mitchross added 5 commits September 16, 2020 14:24

WIP, broken

3d2e034

WIP

3d3aa4c

WIP cast devices

a5fe677

wip cast

e3f9232

WIP - Casting

582924c

alr2413 added 4 commits September 18, 2020 19:49

Merge pull request #2 from mitchross/cast-devices-ios

efeee7b

[DRAFT] WIP - Cast devices ios

refactor a part of ios code

d502c22

updated changelog and version

5952bc1

fix ios cast to device

00180fc

alr2413 added 2 commits September 20, 2020 16:21

Updated Readme

ae06271

fix minor issue in android capture method added event dispatcher to ios cast device add/remove updated example code

Updated Readme

ff22cd6

fix spacing issue in readme

solid-software suggested changes Sep 21, 2020

View reviewed changes

Clean code

50b5bdf

Updated method docs

solid-software approved these changes Sep 22, 2020

View reviewed changes

solid-software merged commit 2b019c8 into solid-software:master Sep 22, 2020

pharshdev mentioned this pull request Sep 25, 2020

Android plugin V2 Migration #113

Closed

shichunlei mentioned this pull request Oct 14, 2020

Message from debugger: Terminated due to memory issue #121

Open

lrorpilla mentioned this pull request Feb 8, 2021

Black screen orientation issues in 5.0.3 on Android, No implementation found on iOS #177

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add many more helper methods to player #104

Add many more helper methods to player #104

alr2413 commented Sep 9, 2020 •

edited

alr2413 commented Sep 9, 2020 •

edited

topilski commented Sep 10, 2020

csongorkeller commented Sep 10, 2020

csongorkeller commented Sep 10, 2020

alr2413 commented Sep 10, 2020 •

edited

topilski commented Sep 10, 2020

alr2413 commented Sep 10, 2020

solid-software commented Sep 11, 2020

mitchross left a comment

alr2413 left a comment

mitchross commented Sep 11, 2020

csongorkeller commented Sep 12, 2020

alr2413 commented Sep 12, 2020

csongorkeller commented Sep 12, 2020 •

edited

mitchross commented Sep 12, 2020

csongorkeller commented Sep 14, 2020

mitchross commented Sep 17, 2020

topilski commented Sep 18, 2020

mitchross commented Sep 18, 2020

mitchross commented Sep 18, 2020

topilski commented Sep 19, 2020

alr2413 commented Sep 21, 2020 •

edited

solid-software left a comment

alr2413 commented Sep 21, 2020 •

edited

mitchross commented Sep 21, 2020

solid-software left a comment

alr2413 commented Sep 22, 2020 •

edited

pharshdev commented Sep 22, 2020

mitchross commented Sep 22, 2020

alr2413 commented Sep 22, 2020

Add many more helper methods to player #104

Add many more helper methods to player #104

Conversation

alr2413 commented Sep 9, 2020 • edited

alr2413 commented Sep 9, 2020 • edited

topilski commented Sep 10, 2020

csongorkeller commented Sep 10, 2020

csongorkeller commented Sep 10, 2020

alr2413 commented Sep 10, 2020 • edited

topilski commented Sep 10, 2020

alr2413 commented Sep 10, 2020

solid-software commented Sep 11, 2020

mitchross left a comment

Choose a reason for hiding this comment

alr2413 left a comment

Choose a reason for hiding this comment

mitchross commented Sep 11, 2020

csongorkeller commented Sep 12, 2020

alr2413 commented Sep 12, 2020

csongorkeller commented Sep 12, 2020 • edited

mitchross commented Sep 12, 2020

csongorkeller commented Sep 14, 2020

mitchross commented Sep 17, 2020

topilski commented Sep 18, 2020

mitchross commented Sep 18, 2020

mitchross commented Sep 18, 2020

topilski commented Sep 19, 2020

alr2413 commented Sep 21, 2020 • edited

solid-software left a comment

Choose a reason for hiding this comment

alr2413 commented Sep 21, 2020 • edited

mitchross commented Sep 21, 2020

solid-software left a comment

Choose a reason for hiding this comment

alr2413 commented Sep 22, 2020 • edited

pharshdev commented Sep 22, 2020

mitchross commented Sep 22, 2020

alr2413 commented Sep 22, 2020

alr2413 commented Sep 9, 2020 •

edited

alr2413 commented Sep 9, 2020 •

edited

alr2413 commented Sep 10, 2020 •

edited

csongorkeller commented Sep 12, 2020 •

edited

alr2413 commented Sep 21, 2020 •

edited

alr2413 commented Sep 21, 2020 •

edited

alr2413 commented Sep 22, 2020 •

edited