Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to use PlatformViewLink instead of AndroidView #313

Closed
XuanTung95 opened this issue Apr 25, 2022 · 3 comments
Closed

Add options to use PlatformViewLink instead of AndroidView #313

XuanTung95 opened this issue Apr 25, 2022 · 3 comments

Comments

@XuanTung95
Copy link
Contributor

Actual:
In my environment AndroidView is laggy, PlatformViewLink is smooth. #102492

Currently, it's hard-coded to use AndroidView

Expected:
Add option to choose between AndroidView and PlatformViewLink.

It's easy to implement but I think it needs to change this interface (add parameter):

  /// Returns a widget displaying the video.
  Widget buildView(PlatformViewCreatedCallback onPlatformViewCreated) {
    throw _unimplemented('buildView');
  }
@illia-romanenko
Copy link
Collaborator

Hi @XuanTung95, feel free to submit a PR, we would be happy to merge it.

@XuanTung95
Copy link
Contributor Author

Please check my PR #314

@solid-software
Copy link
Collaborator

Merged fix. Thanks for your contribution @XuanTung95 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants