fix: Return 409 when there is a slash semantics issue

CommunitySolidServer · Oct 15, 2021 · fb3a59c · fb3a59c
1 parent 76c87bb
commit fb3a59c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/storage/DataAccessorBasedStore.ts b/src/storage/DataAccessorBasedStore.ts
@@ -193,7 +193,7 @@ export class DataAccessorBasedStore implements ResourceStore {
     // requests for the latter URI with a 301 redirect to the former."
     // https://solid.github.io/specification/protocol#uri-slash-semantics
     if (oldMetadata && oldMetadata.identifier.value !== identifier.path) {
-      throw new ForbiddenHttpError(`${identifier.path} conflicts with existing path ${oldMetadata.identifier.value}`);
+      throw new ConflictHttpError(`${identifier.path} conflicts with existing path ${oldMetadata.identifier.value}`);
     }
 
     const isContainer = this.isNewContainer(representation.metadata, identifier.path);

diff --git a/test/unit/storage/DataAccessorBasedStore.test.ts b/test/unit/storage/DataAccessorBasedStore.test.ts
@@ -358,7 +358,7 @@ describe('A DataAccessorBasedStore', (): void => {
       representation.metadata.identifier = DataFactory.namedNode(`${resourceID.path}/`);
       const prom = store.setRepresentation(resourceID, representation);
       await expect(prom).rejects.toThrow(`${resourceID.path} conflicts with existing path ${resourceID.path}/`);
-      await expect(prom).rejects.toThrow(ForbiddenHttpError);
+      await expect(prom).rejects.toThrow(ConflictHttpError);
     });
 
     it('throws a 412 if the conditions are not matched.', async(): Promise<void> => {