change: validate config in precommit and in CI #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
requested changes
Sep 1, 2020
package.json
Outdated
| @@ -22,11 +22,12 @@ | |||
| "prepare": "npm run build", | |||
| "start": "node ./bin/server.js -p 3000", | |||
| "test": "jest", | |||
| "validate": "componentsjs-compile-config urn:solid-server:my -c config/config-default.json > /dev/null", | |||
There was a problem hiding this comment.
Ah yeah, that's because #98 is not merged yet.
There was a problem hiding this comment.
It is now so you can change it 😉
There was a problem hiding this comment.
Done :)
But it looks like the build fails because LSD is down... :-(
There was a problem hiding this comment.
Yay :) Then this should be good to go once @RubenVerborgh approves.
rubensworks
force-pushed
the
change/validate-config
branch
from
6d0c46e
to
0f31991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small addition that ensures our default config is always valid.