fix: Return 409 when there is a slash semantics issue #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this the 2.0.0 branch will completely pass the conformance test harness (tested here).
But (and this is an important but), this is actually a revert of a revert. Originally we returned 409 in this case, but at some point it was mentioned that this should be a 403: #475 (comment)
Which resulted in a discussion and eventually a spec issue that is still open: solid/specification#219
So perhaps it's the test harness that has to change. But seeing as this will probably not be decided in a day and I do want our server to pass the test harness until this is decided, it's probably easiest to just return 409 for now.