add: Add VoidLocker and unittest #1096
Conversation
src/util/locking/VoidLocker.ts
Outdated
| return whileLocked((): void => { | ||
| // eslint:disable-next-line:no-empty | ||
| }); |
There was a problem hiding this comment.
| return whileLocked((): void => { | |
| // eslint:disable-next-line:no-empty | |
| }); | |
| return whileLocked(noop); |
with noop a constant defined on top.
There was a problem hiding this comment.
Thanks for your suggestions.
There was a problem hiding this comment.
One thing that is still missing is a config option. We would need a config/util/resource-locker/debug-void.json that sets the urn:solid-server:default:ResourceLocker to this specific locker, and an extra line in config/util/README.md explaining it. It should have a similar warning as for example config/ldp/authentication/debug-test-agent.json.
The release notes can then mention that this is how this locking mechanism can be enabled.
Co-authored-by: Ruben Verborgh <ruben@verborgh.org>
Co-authored-by: Joachim Van Herwegen <joachimvh@gmail.com>
…erver into feat/void-locker
lina1101
force-pushed
the
feat/void-locker
branch
from
d6242b6
to
7307e73
Compare
Co-authored-by: Joachim Van Herwegen <joachimvh@gmail.com>
Co-authored-by: Joachim Van Herwegen <joachimvh@gmail.com>
| } | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
@lina1101 for some reason git does not agree with your newline, could you have a look what's going on here? Perhaps a non-unix newline?
lina1101
force-pushed
the
feat/void-locker
branch
from
5894b07
to
e35999d
Compare
|
Great, well done all 👍 |
📁 Related issues
Closes: #1093 (comment)
✍️ Description
This is an implementation of VoidLocker.