feat: Add support for N3 Patch #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I forgot to do in this PR (just saw it in my notes but forgot to implement): the n3 patch and sparql update body parsers should be wrapped in a class that only can handle PATCH requests. Probably the same class as in #1119 . Otherwise it would be impossible to store non-patch N3 documents after this change. |
RubenVerborgh
approved these changes
Jan 20, 2022
| @@ -14,11 +14,11 @@ | |||
| { | |||
| "comment": "Makes sure PATCH operations on containers target the metadata.", | |||
| "@type": "ContainerPatcher", | |||
| "patcher": { "@type": "SparqlUpdatePatcher" } | |||
| "patcher": { "@id": "urn:solid-server:default:PatchHandler_Type" } | |||
There was a problem hiding this comment.
I find the _Type suffix weird. Why is it not just urn:solid-server:default:PatchHandlers?
There was a problem hiding this comment.
I find that to be a bit too generic. Could go for urn:solid-server:default:PatchHandler_RDF since this is the handler that is wrapped by other patch handlers that convert to quads first.
joachimvh
force-pushed
the
feat/static-throw-handlers
branch
from
7ddc716
to
e3e3982
Compare
joachimvh
force-pushed
the
feat/n3-patch
branch
from
4078642
to
ecb6681
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📁 Related issues
Closes #1060
✍️ Description
Depends on #1119 due to changes in the PATCH configuration there.
Fully adds support for N3 patch as described in the spec.
Integration tests are based on those in NSS, making N3 Patch probably the most comprehensively tested part of the codebase.