refactor: Remove RuntimeConfig in favor of config variables, Closes #106 #148
Conversation
rubensworks
force-pushed
the
refactor/runtimeconfig
branch
from
a88c62e
to
d10623e
Compare
|
Build fails at the moment because |
There was a problem hiding this comment.
Amazing work, and exactly what we needed!
Best to merge after #142, which touches some of this.
config/config-default.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "files-scs:config/presets/ldp/request-parser.json", | |||
| "files-scs:config/presets/setup.json", | |||
| "files-scs:config/presets/storage.json", | |||
| "files-scs:config/presets/storage_wrapper.json" | |||
| "files-scs:config/presets/storage_wrapper.json", | |||
| "files-scs:config/presets/variables.json" | |||
There was a problem hiding this comment.
Maybe give a more descriptive name? Here it can be runtime-settings or cli-params for me.
| "@id": "urn:solid-server:default:variable:base" | ||
| }, | ||
| "Setup:_port": { | ||
| "@id": "urn:solid-server:default:variable:port" |
src/init/CliRunner.ts
Outdated
| config: { type: 'string', alias: 'c' }, | ||
| }) | ||
| .help(); | ||
|
|
||
| new Promise<RuntimeConfig>(async(resolve): Promise<void> => { | ||
| new Promise<string>(async(resolve, reject): Promise<void> => { |
There was a problem hiding this comment.
The whole promise wrap thingy is weird here. Can't we just make this entire function async?
There was a problem hiding this comment.
…or if we can't, just call an async function that does it?
There was a problem hiding this comment.
Link to @rubensworks reply when I asked the same thing. But yea, moving this part to a separate async function could make it cleaner.
rubensworks
force-pushed
the
refactor/runtimeconfig
branch
from
d10623e
to
ea41454
Compare
|
Resolved all comments and rebased. So this one should be good to go once Travis finishes. |
|
@rubensworks can you rebase this to master? I'll wait with the metadata PRs until this is merged to make the rebase easier 😄 |
rubensworks
force-pushed
the
refactor/runtimeconfig
branch
from
ea41454
to
09f4c28
Compare
|
@joachimvh Done |
rubensworks
force-pushed
the
refactor/runtimeconfig
branch
from
09f4c28
to
c29837e
Compare
|
Another victim of the "rebase doesn't run pre-commit checks" feature |
|
That's why we have Travis :) |
This uses the new Components.js variables functionality.