refactor: Make URI constants consistent #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
approved these changes
Sep 11, 2020
| @@ -0,0 +1,65 @@ | |||
| const createSuffixFn = (prefix: string): any => (suffix: string): string => `${prefix}${suffix}`; | |||
There was a problem hiding this comment.
Suggested change
| const createSuffixFn = (prefix: string): any => (suffix: string): string => `${prefix}${suffix}`; | |
| const createNamespace = (prefix: string): any => (suffix: string): string => `${prefix}${suffix}`; |
| * so only use this for internal constants! | ||
| * @param name - Predicate to potentially transform. | ||
| */ | ||
| export const getNamedNode = (name: NamedNode | string): NamedNode => { |
There was a problem hiding this comment.
Suggested change
| export const getNamedNode = (name: NamedNode | string): NamedNode => { | |
| export const toNamedNode = (name: NamedNode | string): NamedNode => { |
| * Converts an object to a literal when needed. | ||
| * @param object - Object to potentially transform. | ||
| */ | ||
| export const getObjectTerm = (object: NamedNode | Literal | string): NamedNode | Literal => |
There was a problem hiding this comment.
Suggested change
| export const getObjectTerm = (object: NamedNode | Literal | string): NamedNode | Literal => | |
| export const toObjectTerm = (object: NamedNode | Literal | string): NamedNode | Literal => |
| * @param object - Object value. | ||
| * @param dataType - Object data type (as string). | ||
| */ | ||
| export const getTypedLiteral = (object: string | number, dataType: string): Literal => |
There was a problem hiding this comment.
Suggested change
| export const getTypedLiteral = (object: string | number, dataType: string): Literal => | |
| export const toTypedLiteral = (object: string | number, dataType: string): Literal => |
rubensworks
approved these changes
Sep 14, 2020
joachimvh
force-pushed
the
refactor/uris
branch
from
9090515
to
1da81f9
Compare
joachimvh
force-pushed
the
refactor/uris
branch
from
1da81f9
to
0bf5e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores all our URI constants in 1 file now. They are stored as strings and not as named nodes so they can be used in the objectmap of the RepresentationMetadata constructor. This PR does also add some helper functions to cache the named nodes we generate from them to prevent having to do that all the time.