Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4.
I made a separate commit for the naming-convention rule since that one can still cause some discussion. This was the original rule in the config we're using.
Using the original rule as it was written required us to have all our boolean parameters/variables start with has/is/etc. This caused issues with many external calls such as enabling
quad
mode for SparqlAlgebra.js, settingobjectMode
for Node streams, etc. There were several files where I needed to disable the rule for multiple lines (and there were still 150 errors remaining when I gave up). It also would require us to change our permissions object from read/write/append to canRead/canWrite/canAppend which is less clean imo.I then tried using a combination of the default settings and the config by still using strictCamelCase and StrictPascalCase, but that has as disadvantage that we for example can never use
URI
as part of a variable. E.g, can't have a variable calledchildURIs
, would have to bechildUris
. Same forbaseIRI
, etc.So I just used normal camel case/Pascal case rules since URIs/IRIs are sort of important for Solid. But this one is a separate commit so it can still easily be changed.
Still have to disable the rule in the URI constants file but that was to be expected.