fix: Have AsyncHandlers only check what is necessary #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
approved these changes
Oct 5, 2020
src/ldp/http/BasicResponseWriter.ts
Outdated
| @@ -12,7 +12,7 @@ export class BasicResponseWriter extends ResponseWriter { | |||
| public async canHandle(input: { response: HttpResponse; result: ResponseDescription | Error }): Promise<void> { | |||
| if (!(input.result instanceof Error)) { | |||
| if (input.result.body && !input.result.body.binary) { | |||
There was a problem hiding this comment.
Why double if here? (and why doesn't the linter guard this?)
There was a problem hiding this comment.
True, actually surprised it didn't complain about this.
| const contentType = input.headers['content-type']; | ||
|
|
||
| if (!contentType || contentType !== 'application/sparql-update') { | ||
| if (input.headers['content-type'] !== 'application/sparql-update') { |
There was a problem hiding this comment.
Maybe both should be a constant (definitely the second).
joachimvh
force-pushed
the
canHandle-checks
branch
from
9b262cd
to
8347634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #119 .
Also cleaned up some canHandle functions.
IMO it's not always clearcut when something should be in
canHandleorhandle, but this should solve the more clear cases.