SPARQL updates #34
SPARQL updates #34
Conversation
|
|
||
| public async handle(input: HttpRequest): Promise<SparqlUpdatePatch> { | ||
| try { | ||
| const sparql = (await arrayifyStream(input)).join('\n'); |
There was a problem hiding this comment.
I suspect this stringification will be needed by many body parsers. We may want to consider abstracting this in BodyParser. (not urgent though)
There was a problem hiding this comment.
I'm confused by the \n; that surely must be a mistake? They should just be concatenated?
But yes, isn't there a simple arrayToString somewhere? (And if not, let's write it?)
There was a problem hiding this comment.
Yea no reason for the \n to be there. Probably just seemed nicer in my head at the time to have everything on separate lines.
It is readableToString that is needed here (and the function for that would be that line, can put it in util).
There was a problem hiding this comment.
no reason
Even worse, it would mess up chunked input 😉
| // Prevent body from being requested again | ||
| return { | ||
| algebra, | ||
| dataType: 'algebra', |
There was a problem hiding this comment.
Not sure if 'algebra' is descriptive enough for this. Maybe we want 'sparqlAlgebra' or 'sparql-algebra'?
|
|
||
| public async handle(input: HttpRequest): Promise<SparqlUpdatePatch> { | ||
| try { | ||
| const sparql = (await arrayifyStream(input)).join('\n'); |
There was a problem hiding this comment.
I'm confused by the \n; that surely must be a mistake? They should just be concatenated?
But yes, isn't there a simple arrayToString somewhere? (And if not, let's write it?)
src/storage/PatchStore.ts
Outdated
| * If the original store supports the {@link Patch}, behaviour will be identical, | ||
| * otherwise one of the {@link PatchHandler}s supporting the given Patch will be called instead. | ||
| */ | ||
| export class PatchStore implements ResourceStore { |
There was a problem hiding this comment.
Maybe PatchingStore or PatcheableStore or something (to avoid the impression that it stores patches)?
This adds support for SPARQL updates through PATCH requests. Currently only deletes/inserts without variables are supported (will need to look into an internal querying engine potentially for more advanced queries).
The main "special" thing is probably how the input body is handled in a Patch. To prevent multiple parsings, the body parser immediately reads the body and parses it into the algebra. The data field then throws an error if it would still be accessed afterwards (which should never happen since every class that uses a Patch would know of the interface). This was already somewhat discussed with @RubenVerborgh but this can still change of course.