Add support for parsing more RDF formats using rdf-parse #84
Conversation
| return this.turtleToQuads(input.representation, input.identifier.path); | ||
| } | ||
|
|
||
| private turtleToQuads(representation: Representation, baseIRI: string): Representation { |
There was a problem hiding this comment.
Probably should also rename the function then.
| ...representation.metadata.contentType ? | ||
| { contentType: representation.metadata.contentType } : | ||
| { path: baseIRI }, |
There was a problem hiding this comment.
checkRequest in the canHandle call above is going to error if there is no contentType so you can assume it exists. The Solid spec currently says to reject PUT/POST/PATCH without content-type as well.
There was a problem hiding this comment.
Oh ok, that makes our lives easier here :)
| data = errorStream; | ||
| setImmediate((): boolean => data.emit('error', | ||
| new UnsupportedHttpError('Could not find a valid content type or known file extension.'))); |
There was a problem hiding this comment.
If this catch can only occur when there is no content-type I would also drop this part then (since it means there is an internal server problem if we get to this point).
rubensworks
force-pushed
the
feature/rdf-parse
branch
from
1220f13
to
76d2f69
Compare
|
Should we drop Generic from the name? |
Yea would probably be better. |
Done :) |
rubensworks
force-pushed
the
feature/rdf-parse
branch
from
76d2f69
to
8b64c2e
Compare
You forgot to edit the class name 😅 |
|
Heh, for some reason my webstorm didn't apply all changes... |
rubensworks
force-pushed
the
feature/rdf-parse
branch
from
8b64c2e
to
8fbe9ee
Compare
A simple addition that allows us to automatically parse all major RDF formats: https://github.com/rubensworks/rdf-parse.js#rdf-parse