feat: Create ChainedTemplateEngine for combining engines #887
Conversation
There was a problem hiding this comment.
The title extraction is now done in the main IDP template, but after doing this I actually think it would be better to have a separate engine for this. That way we can reuse the root main.html.hbs template for the IDP
I might be missing something, but why don't we use main.html.ejs as the main template of everything? (And remove the existing title-extracting code in MarkdownToHtmlConverter?)
Probably because I still have this "remove ejs" idea in my head. Yea that would work as well I think. |
joachimvh
force-pushed
the
feat/chained-templates
branch
from
683a4f1
to
5877f9b
Compare
| @@ -34,7 +34,7 @@ export class ResetPasswordHandler extends InteractionHandler { | |||
| assertPassword(password, confirmPassword); | |||
|
|
|||
| await this.resetPassword(recordId, password); | |||
| return { type: 'response', details: { message: 'Your password was successfully reset.' }}; | |||
| return { type: 'response', details: {}}; | |||
There was a problem hiding this comment.
Make details optional? (minor nit)
templates/identity/email-password/forgot-password-response.html.ejs
Outdated
Show resolved
Hide resolved
joachimvh
force-pushed
the
feat/chained-templates
branch
from
5877f9b
to
5d86c87
Compare
Closes #872 .
The title extraction is now done in the main IDP template, but after doing this I actually think it would be better to have a separate engine for this. That way we can reuse the root
main.html.hbstemplate for the IDP (now we have 2 almost-identical main templates), and we can then also attach that to the templating engine used in theMarkdownToHtmlConverter, which now does its own title extraction.But I already had this working version when I realized that so I thought I might as well already push this to hear a 2nd opinion on how needed this is. 馃槃