refactor: Clean up internal storage #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
approved these changes
Sep 7, 2021
| @@ -13,26 +13,46 @@ | |||
| "@type": "JsonResourceStorage", | |||
| "source": { "@id": "urn:solid-server:default:ResourceStore_Backend" }, | |||
| "baseUrl": { "@id": "urn:solid-server:default:variable:baseUrl" }, | |||
| "container": "/locks/" | |||
| "container": "/internal/locks/" | |||
There was a problem hiding this comment.
Perhaps
Suggested change
| "container": "/internal/locks/" | |
| "container": "/.internal/locks/" |
Each IDP class using storage now has a different storage. This way those classes don't have to worry about clashing keys anymore. All internal storage is now in the /.internal/ container, thereby making it easier to take the location of the internal data into account: only 1 path needs to be blocked and a regex router handling internal data differently only has to match 1 path as well.
joachimvh
force-pushed
the
refactor/storage
branch
from
b32917b
to
6a99f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each IDP class using storage now has a different storage. This way those classes don't have to worry about clashing keys anymore.
All internal storage is now in the /internal/ container, thereby making it easier to take the location of the internal data into account: only 1 path needs to be blocked and a regex router handling internal data differently only has to match 1 path as well.
This also makes it less invasive to add a new storage somewhere in the future.
Might also help with #892