fix: Let Representations always have a body #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 11, 2021
RubenVerborgh
approved these changes
Oct 12, 2021
This is relevant when the request has a content-type but no data.
joachimvh
force-pushed
the
fix/empty-body
branch
from
495a282
to
0a98c80
Compare
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #982 and indirectly closes #969 (since we now accept empty/missing bodies).
Operation.bodyis no longer optional.Representationhas a newisEmptyparameter, which in practice is a shortcut for checking if there is a content-type.I looked into having the
datafield of a Representation be optional, but the problem is that classes then no longer can be sure they get a data stream from functions that return a Representation. It would also potentially cause confusion between an empty data stream and an undefined one.