Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some default styles are missing from mash.css #66

Closed
megoth opened this issue Aug 27, 2019 · 3 comments
Closed

Some default styles are missing from mash.css #66

megoth opened this issue Aug 27, 2019 · 3 comments
Assignees

Comments

@megoth
Copy link
Contributor

megoth commented Aug 27, 2019

In one of the newer iterations we introduced reset.css which strips a lot of default styles. This might've been a bit too much, as headers now look like any other text.

I suggest we either:

  1. Remove the use of reset.css altogether, or a subset of the styles we do not want to use, or
  2. Apply some styles we want to have as a common baseline, at least for headers

We might also postpone this until we have a proper solution for how we want to handle styles in the data browser in general.

@megoth megoth added this to To do in Data Browser via automation Aug 27, 2019
@Vinnl
Copy link
Contributor

Vinnl commented Aug 28, 2019

I'd postpone this to be part of the UX work we should incorporate in our planning process later; the current data browser doesn't have a clear information hierarchy anyway.

@Vinnl Vinnl closed this as completed Aug 28, 2019
Data Browser automation moved this from To do to Done Aug 28, 2019
@Vinnl Vinnl reopened this Aug 28, 2019
Data Browser automation moved this from Done to To do Aug 28, 2019
@Vinnl
Copy link
Contributor

Vinnl commented Aug 28, 2019

Btw, quick fix might be: https://necolas.github.io/normalize.css/ instead of a reset.

@megoth megoth moved this from To do to In progress in Data Browser Aug 29, 2019
@megoth megoth self-assigned this Aug 29, 2019
@megoth megoth moved this from In progress to Needs review in Data Browser Aug 29, 2019
@megoth megoth mentioned this issue Aug 29, 2019
@Vinnl
Copy link
Contributor

Vinnl commented Aug 29, 2019

Fixed by #68.

@Vinnl Vinnl closed this as completed Aug 29, 2019
Data Browser automation moved this from Needs review to Done Aug 29, 2019
@megoth megoth moved this from Done to Release 2 in Data Browser Sep 2, 2019
@brownhoward brownhoward added this to the Data Browser Release 2 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants