Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting for changes in global dashboard in solid-panes #67

Merged
merged 2 commits into from Sep 2, 2019
Merged

Adjusting for changes in global dashboard in solid-panes #67

merged 2 commits into from Sep 2, 2019

Conversation

megoth
Copy link
Contributor

@megoth megoth commented Aug 27, 2019

Although the changes in databrowser.html and browser.html is not necessary, it is easier to read the code if the new elements are introduced.

This fixes SolidOS/solid-panes#154 and is dependent on changes in SolidOS/solid-panes#166

@megoth
Using changes in solid-panes
9660f9a 
Although the changes in databrowser.html and browser.html is not necessary, it is easier to read the code if the new elements are introduced.

This fixes SolidOS/solid-panes#154 and is dependent on changes in SolidOS/solid-panes#166
@megoth megoth requested review from Vinnl and timbl August 27, 2019 20:27
@megoth megoth added this to To do in Data Browser via automation Aug 27, 2019
@megoth megoth mentioned this pull request Aug 27, 2019
Merged
@megoth megoth moved this from To do to Needs review in Data Browser Aug 27, 2019
Vinnl
Vinnl suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@Vinnl Vinnl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the proper way to implement this is to release solid-panes v2 first, and then update this PR to update the dependency to include that.

The code looks good to me, anyway :)

@megoth megoth moved this from Needs review to In progress in Data Browser Aug 28, 2019
@megoth megoth moved this from In progress to Needs review in Data Browser Aug 28, 2019
@megoth megoth changed the title Using changes in solid-panes Adjusting for changes in global dashboard in solid-panes Aug 28, 2019
timbl
timbl approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@megoth megoth moved this from Needs review to On hold in Data Browser Aug 29, 2019
@megoth megoth moved this from On hold to Needs review in Data Browser Aug 29, 2019
@megoth megoth moved this from Needs review to On hold in Data Browser Aug 30, 2019
@megoth megoth moved this from On hold to Done in Data Browser Aug 30, 2019
@megoth megoth mentioned this pull request Sep 2, 2019
Closed
@megoth megoth merged commit 210e1ba into master Sep 2, 2019
@megoth megoth deleted the global-dashboard branch September 2, 2019 12:09
@megoth megoth moved this from Done to Release 2 in Data Browser Sep 2, 2019
@brownhoward brownhoward added this to the Data Browser Release 2 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinnl Vinnl Vinnl approved these changes

@timbl timbl timbl approved these changes

Assignees
No one assigned
Labels
release-minor
Projects
None yet
Milestone
Data Browser Release 2
Development

Successfully merging this pull request may close these issues.

Global panes should replace the view for normal panes
4 participants
@megoth @Vinnl @timbl @brownhoward