Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAC-Allow doesn't seem to depend on resource #973

Open
kjetilk opened this issue Nov 26, 2018 · 2 comments
Open

WAC-Allow doesn't seem to depend on resource #973

kjetilk opened this issue Nov 26, 2018 · 2 comments
Assignees
@jaxoncreed
Labels
good first issue An issue that should be quite easy for newcomers to fix

Comments

@kjetilk
Copy link
Member

kjetilk commented Nov 26, 2018 •
edited

Looking at the code in
https://github.com/solid/node-solid-server/blob/adb0691a787d65e41cfd9e32d4496d8a0b4f98ed/lib/header.js#L132
it doesn't seem like #246 was implemented with resource, because that parameter doesn't seem to be used.
@RubenVerborgh
Copy link
Contributor

Indeed, resource is implicitly in acl.

@megoth megoth assigned megoth and unassigned megoth Nov 26, 2018
@megoth megoth added the triage Issues that need team review label Nov 26, 2018
@kjetilk kjetilk added inrupt-planning Issues that Inrupt will consider when planning development cycles and removed triage Issues that need team review labels Dec 18, 2018
@megoth megoth added this to To do in NSS-5.0.0 via automation Dec 18, 2018
@kjetilk kjetilk removed the inrupt-planning Issues that Inrupt will consider when planning development cycles label Apr 1, 2019
@kjetilk
Copy link
Member Author

kjetilk commented Jul 4, 2019 •
edited

Perhaps you want to take this little trivial thing @jaxoncreed , just a cleanup?

@jaxoncreed jaxoncreed added this to To do in Node Solid Server via automation Jul 8, 2019
@jaxoncreed jaxoncreed added the good first issue An issue that should be quite easy for newcomers to fix label Nov 6, 2019
@bourgeoa bourgeoa removed this from To do in NSS-5.0.0 Apr 26, 2022
@bourgeoa bourgeoa removed this from To do in Node Solid Server Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaxoncreed jaxoncreed

Labels
good first issue An issue that should be quite easy for newcomers to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kjetilk @RubenVerborgh @megoth @jaxoncreed