Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

GitHub templates #5

Merged
merged 1 commit into from Oct 21, 2018

Conversation

m14t
Copy link
Contributor

@m14t m14t commented Oct 19, 2018

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

What does this PR do?

This PR adds both a Pull Request Template, and a template for both bug fixes and feature requests using multiple template types.

Links to relevant issues:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • All tests are passing N/A
  • New/updated tests are included N/A

Other information:
Once this PR is merged, when a user clicks on "New Issue" they will be directed to https://github.com/solid/react-components/issues/new/choose, which will display a screen like:
screen shot 2018-10-19 at 8 20 12 am

@RubenVerborgh
Copy link
Owner

😲 Did you just adhere to your own template? 😄

Great job, will add this before the v1.0.0 release this weekend.

@johanbove
Copy link

These templates will make the PR descriptions very useful when it comes to creating release notes and managing releases. Great job @m14t

@RubenVerborgh RubenVerborgh force-pushed the feature/github-templates branch 2 times, most recently from 1bcb35e to 2d09ef3 Compare October 21, 2018 12:17
@coveralls
Copy link

coveralls commented Oct 21, 2018

Pull Request Test Coverage Report for Build 30

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 28: 0.0%
Covered Lines: 95
Relevant Lines: 95

💛 - Coveralls

@RubenVerborgh RubenVerborgh merged commit e8f816d into RubenVerborgh:master Oct 21, 2018
@RubenVerborgh
Copy link
Owner

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants