Separating dashboard and outline #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megoth
added a commit
to SolidOS/mashlib
that referenced
this pull request
Aug 27, 2019
Although the changes in databrowser.html and browser.html is not necessary, it is easier to read the code if the new elements are introduced. This fixes SolidOS/solid-panes#154 and is dependent on changes in SolidOS/solid-panes#166
|
The corresponding changes in mashlib can be found at SolidOS/mashlib#67 |
Vinnl
approved these changes
Aug 28, 2019
timbl
approved these changes
Aug 29, 2019
megoth
added a commit
that referenced
this pull request
Aug 29, 2019
Based on Tims feedback - #166 (comment)
megoth
added
the
release-major
No reason to reuse elements from the outline container that is used for displaying panes for a given subject. This commit separates the logic for the two, and handles switching between them. Not done any styling on cancel button, as I want to know how Tim wants to have it first. This fixes #154
This presents a cancelButton next to the tabs. This relies on changes in https://github.com/solid/solid-ui/pull/110
Based on Tims feedback - #166 (comment)
megoth
force-pushed
the
global-dashboard
branch
from
018c0b7
to
da8e8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to reuse elements from the outline container that is used for displaying panes for a given subject.
This commit separates the logic for the two, and handles switching between them.
Not done any styling on cancel button, as I want to know how Tim wants to have it first.
This fixes #154
This has some breaking changes in API that mashlib uses, and mashlib will require these commit to continue functioning.