Adding audience to panes and filtering based on that and user roles #168
Conversation
Making it easier to add extra logic that takes what kind of user the user is
This is dependent on solid/solid-ui#112, so do not merge this until it has been merged and released and the PR has been updated with corresponding release version.
|
This PR should also include an update to issue-pane after SolidOS/issue-pane#1 has been merged. |
|
This PR should also include an update to meeting-pane after SolidOS/meeting-pane#1 has been merged. |
|
This PR should also include an update to folder-pane after SolidOS/folder-pane#3 has been merged. |
|
This is part of fixing #167 |
There was a problem hiding this comment.
It is important that when a user is looking at an object (like a meting or a bank transaction ) where there is a hand-coded view, then they must be given that view, whether or not they are an expert user. It is very bad to deprive them of the proper view and give them a raw data view! We can I suppose detect that as the highest priority pane in the way the pane system works at the moment, though we cloudl cahnge that to haveing q values for each pane.
There was a problem hiding this comment.
LGTM; setting it to "Request changes" to make sure the upgrade to a new major version of solid-ui with https://github.com/solid/solid-ui/pull/112 is included.
Should've been removed in earlier commit
Handle the case that Tim describes in #168 (review)
megoth
added
the
release-minor
| @@ -380,8 +380,21 @@ module.exports = function (doc) { | |||
|
|
|||
| async function getRelevantPanes (panes, subject, dom) { | |||
| const relevantPanes = panes.list.filter(pane => pane.label(subject, dom) && !pane.global) | |||
| if (relevantPanes.length === 0) { | |||
| // there are no relevant panes, simply return default pane (which ironically is internalPane) | |||
There was a problem hiding this comment.
¿¿¿ eh??? The default pane and the internals pane should be quite different. The default pane should the normal properties in a list, excluding things deemed to be internal like the URI itself, the record of attempts to load the URI etc. Those things are shown in the internals pane, which also allows you to refresh the local triple store, delete the file, etc. The default pane is not the internal pane.
There was a problem hiding this comment.
The irony is in the naming - defaultPane sounds like it should be the default pane that is shown.
This is dependent on solid/solid-ui#112, so do not merge this until it has been merged and released and the PR has been updated with corresponding release version.